 |
Regarding the same file in the git (can't make a patch, because I can't figure out what purpose is of the last lines in the file, which are also last lines in the short grep below, so I can't just delete them): $ grep -C3 dir cinelerra-5.1/blds/bld_prepare.sh echo " <os> = [centos | suse | ubuntu]" fi dir="$1" case "$dir" in "centos") yum -y install nasm libavc1394-devel libusbx-devel flac-devel \ libjpeg-devel libdv-devel libdvdnav-devel libdvdread-devel \ -- libxml2-utils git inkscape autoconf automake debhelper libgtk2.0-dev ;; *) echo "unknown os: $dir" exit 1; ;; esac mkdir -p "/home/$dir/git-repo" chmod a+rwx -R "/home/$dir/git-repo" --- I only ran it on Debian, and the first minor bug is on the page linked above. But I guess even if the unknown OS is, say "sabayon", just to give a valid OS, what the bottom lines would do for whichever the $1 arg given to the script were, is, after the run of the script, the user would have something like: $ ls -l /home/ total 48 drwxr-xr-x 11 user1 user1 23646 2019 Jun 14 20:30 user1 drwxr-xr-x 3 root root 4096 2019 Jun 14 20:47 sabayon drwxr-xr-x 54 user2 user2 32768 2019 Jun 14 20:27 user2 And sabayon empty dir would look like: ls -l /home/sabayon/ total 4 drwxrwxrwx 2 root root 4096 2019 Jun 14 20:47 git-repo The "drwxrwxrwx" achieved with: chmod a+rwx -R "/home/$dir/git-repo" is not a good thing. And that dir may not be used, actually should not. And probably the author did not mean it to be like that. Also at the top of grepped output, the line: echo " <os> = [centos | suse | ubuntu]" should probably look different to reflect the actual options. |
- Anonymous
