View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0000359Cinelerra-GG[All Projects] Bugpublic2020-01-01 13:202020-01-28 19:03
Reporterferdnyc Assigned ToPhyllisSmith  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version2019-11 
Target VersionFixed in Version2020-01 
Summary0000359: [PATCH] a52dec header detection fails due to missing stdint.h include
DescriptionLike x264's, the a52dec header (a52.h) needs to have stdint.h included before it,
or configure's detection of it will fail. The attached patch adds stdint.h to the
list of include files to check, fixing detection of a52.h on the system
Steps To Reproducecd cinelerra-5.1
./autogen.sh
./configure --enable-a52dec=auto

Partial output:
checking for a52_init in -la52... yes
checking for a52.h... no
checking a52 headers... no

With patch:
git am 0001-Fix-a52-header-detection.patch
cd cinelerra-5.1
./autogen.sh
./configure --enable-a52dec=auto

Patched output:
checking for a52_init in -la52... yes
checking for stdint.h... (cached) yes
checking a52 headers... yes
Additional Information(The issue is present in the latest 2019-12 snapshot as well, but it isn't in the version selector yet.)
Tagsa52dec, configure

Activities

PhyllisSmith

PhyllisSmith

2020-01-08 00:29

manager   ~0002651

Fix checked into GIT today.
PhyllisSmith

PhyllisSmith

2020-01-01 18:31

manager   ~0002625

Thank you for pointing this out. GG is going to add stdint.h to be checked and will test it here today. It is best to make it as correct as possible even if a moot point as things always change.
ferdnyc

ferdnyc

2020-01-01 13:48

reporter   ~0002624

Hmm... well, as it turns out this is a moot point.

The issue is present, as described. (In addition, a52.h should really be detected as a52dec/a52.h, since it installs on the system as /usr[/local]/include/a52dec/a52.h.)

But it doesn't really matter, because libzmpeg3 expects to link with a static build of liba52. So the system shared library can't be used even if it is correctly detected, because It'll break the libzmpeg3 build.

Issue History

Date Modified Username Field Change
2020-01-01 13:20 ferdnyc New Issue
2020-01-01 13:20 ferdnyc Tag Attached: a52dec
2020-01-01 13:20 ferdnyc Tag Attached: configure
2020-01-01 13:48 ferdnyc Note Added: 0002624
2020-01-01 18:31 PhyllisSmith Note Added: 0002625
2020-01-01 18:31 PhyllisSmith Assigned To => PhyllisSmith
2020-01-01 18:31 PhyllisSmith Status new => confirmed
2020-01-08 00:29 PhyllisSmith Status confirmed => resolved
2020-01-08 00:29 PhyllisSmith Resolution open => fixed
2020-01-08 00:29 PhyllisSmith Fixed in Version => 2020-01
2020-01-08 00:29 PhyllisSmith Note Added: 0002651
2020-01-28 19:03 PhyllisSmith Status resolved => closed