View Issue Details

IDProjectCategoryView StatusLast Update
0000468Cinelerra-GG[All Projects] Bugpublic2020-07-01 01:59
Reporterskinkie Assigned To 
PrioritylowSeveritytrivialReproducibilityalways
Status assignedResolutionopen 
Product Version2020-04 
Target VersionFixed in Version 
Summary0000468: When undo, all video previews are reloaded
DescriptionWhen undo, all video previews are reloaded.
Steps To ReproduceJust make a cut somewhere. Press undo. Notice that the entire project reloads all previews.
TagsNo tags attached.

Activities

PhyllisSmith

PhyllisSmith

2020-07-01 01:55

manager   ~0003719

That is a good summary -- I am going to leave this open in case more programming help shows up who is interested in a better solution. A lot more things to solve, as you said, and you marked this as "low" so we will leave it at that!
skinkie

skinkie

2020-07-01 01:25

reporter   ~0003718

I think here it basically boils down to how the model-view-controller has been implemented. There are cases to be defined where a complete project change would happen (but should this be an undoable action?). But in general being able to tell the difference in the view between model A_t=0 and model A_t-1 (undo) and model A_t+1 (redo) doesn't sound like a bad idea. Sure, there are better things to solve.
PhyllisSmith

PhyllisSmith

2020-07-01 00:58

manager   ~0003716

@skinkie
That is an interesting proposal and would probably work in some cases. But the perplexity of what has been done and undone is troubling. For example, what if you had a project loaded and the last thing you did was a "load project" of a different project. Now with an "undo", you go back to the previous project and there is absolutely no correlation between the before and after states.
skinkie

skinkie

2020-06-30 23:50

reporter   ~0003714

Wouldn't this be possible to evaluate the current loaded state (the current EDL) with the previous EDL to estimate which objects should change? For example by a hash function on the objects state.
PhyllisSmith

PhyllisSmith

2020-06-30 23:08

manager   ~0003711

This can not be changed. When you do an "undo", it is not really inverting the change. The way Cinelerra works is that when changes are made, they are recorded in the EDL (Edit Decision List) so that the original media is preserved and not modified. So when you do an "undo", it is actually loading the project based on the previous EDL from the last commit. It is exactly like as if you opened a previously existing project.

The issue you are referring to is shown in your demo file at approximately 0:00:35:00 -- https://streamable.com/wmvk9d
I will close this issue in a few days in case there is any feedback.

Issue History

Date Modified Username Field Change
2020-06-28 11:22 skinkie New Issue
2020-06-30 23:00 PhyllisSmith Assigned To => PhyllisSmith
2020-06-30 23:00 PhyllisSmith Status new => assigned
2020-06-30 23:08 PhyllisSmith Status assigned => feedback
2020-06-30 23:08 PhyllisSmith Note Added: 0003711
2020-06-30 23:50 skinkie Note Added: 0003714
2020-06-30 23:50 skinkie Status feedback => assigned
2020-07-01 00:58 PhyllisSmith Note Added: 0003716
2020-07-01 01:25 skinkie Note Added: 0003718
2020-07-01 01:55 PhyllisSmith Note Added: 0003719
2020-07-01 01:59 PhyllisSmith Assigned To PhyllisSmith =>