 |
Fixed in June 2023. |
|
|
The June 30 AppImages have the fix in so marking as resolved and will close in a couple of days. |
|
|
Checked into GIT the Delay Audio changes because I have not been able to reproduce any crashes, to include on a 2020 Arch version using Tears of Steel. In addition, besides testing using 5 different video or audio sources on Fedora 32 and the more up to date Fedora 37, Ubuntu 16, Arch 10/2020, and Debian 11.0 32-bit, I had no crashes with the mod in but was able to create the crash without the mod. Not sure what Andrea did differently that he was still able to get a crash. But the patch at least fixes many situations. Note: when rendering the test files before and after the patch, they matched perfectly (except Key_Person_3.xml would not render without crashing before the patch was applied). |
|
|
@Andrea_Paz Still can not get to crash after downloading Tears of Steel mkv version. But I did look at the dmp file you included earlier and it clearly shows delayaudio being the crashing party in process_realtime just like before. I don't think you did anything different than what I have been trying (just moving around, playing at regular speed, and then switching to fast speed forward). I have a really old Arch system that I will test it on next. |
|
|
@Andrea_Paz Still can not get to crash after downloading Tears of Steel mkv version. But I did look at the dmp file you included earlier and it clearly shows delayaudio being the crashing party in process_realtime just like before. I don't think you did anything different than what I have been trying (just moving around, playing at regular speed, and then switching to fast speed forward). I have a really old Arch system that I will test it on next. |
 |
@ PhyllisSmith I used a Blender movie, made freely available: Tears of steel. I used the 1080p version, webm (545MB) in this page: https://mango.blender.org/download/ |
|
|
@Andrea_Paz I have not been able to create any crashes with this patch after recompiling. And the Debian 11.0 32-bit tests worked also. Could you upload the test file you used somewhere (or else email directly only to me) so I can test that file here? |
|
|
Unfortunately, I keep getting the crash when I use fast forward. On the terminal I have the following messages: ** segv at 0x7f165b673e07 in pid 165163, tid 165542 writing debug data to /tmp/cinelerra_165163.dmp lock_items: 33 lock_frees: 4 ** dump complete signal_entry: got SIGHUP my pid=165224 execution table size=0: signal_entry: lock table size=1 lock_items: 0 lock_frees: 1 SigHandler::signal_handler total files=0 I append the dump file. cinelerra_165163.tar.gz (18,556 bytes) |
|
|
@Nafnlaus @Andrea_Paz We have a patch which resolves the crash, but I do not know the exact reason why. Andrew developed the first half of the patch (always reconfigure) and I stumbled across the second half (size is always that of new_allocation). I have tested on Fedora, ubuntu 16 and waiting to test on debian 11.0, 32-bit (it is slowly building there). Test was of 3 files - KeyPerson_3.xml with local substitutions for the aac and mp4 files. It played in all directions and successfully rendered the entire project. Other files were a simple short part of KeyPerson_3.xml with just the aac file and a audio mp3 file only. The audio only file before the patch, would simply crash when switched from play key forward to fast play key forward and now does not crash. Andrea if you could test on Arch, it would be much appreciated. Patch is attached, or you can just make the 3 line changes manually in ...plugins/delayaudio/delayaudio.c. Thanks.
delayaudio_patch.diff (554 bytes) |
|
|
Using "fast forward" I also get the crash. No matter if "play" is on or not, I always get the crash when I click on "fast forward". With F_adelay I don't get crashes. Previously I had tried just "play" and "scrubbing" without getting crash. I attach the dump. cinelerra_1925.tar.gz (17,495 bytes) |
|
|
@Nafnlaus @Andrew-R Simplest demo to create "Delay Audio" plugin problem. I tested this with 4 random audio files or video files that included audio files and all crashed under this set of steps. So you can demo with any file but 1 small example audio file is attached. 1) load/replace file (or load to resources and then drag onto timeline) 2) drag the "Delay Audio" plugin to the audio track 3) start playing file from the beginning (or start anywhere) 4) without stopping first, use the "fast forward" icon in the main window to speed up the playing - CRASH ALTERNATIVE to "Delay Audio" is "F_adelay" which did not crash for me - set "delays" parameter to desired seconds and use "Apply". Next I will use the debugger to learn some more. audio_snippet.mp4 (582,066 bytes) |
 |
I really appreciate you working on this. People like you are the glue that holds projects together :) |
|
|
@Nafnlaus Changing computers easily caused the crash - but in my case even with "Delay Audio" eliminated, it crashes. So I will have to try to narrow down the circumstances. Just FYI, in the KeyPerson_3.xml file, I substituted my own .mp4 and .aac files so the crash is definitely not dependent on your particular set of files. It may take me awhile to find the cause so it is a good thing you have a workaround. If I can think of anything else you can do to help, I will let you know. Not important, but this crash dates back to at least April 2020 but since Chorus plugin was not added until 11/2019, can not use XML file before that. At least this eliminates anything we may have changed since November 2020. |
|
|
Let me know if there's anything else I can do to help :) |
|
|
@Nafnlaus Been trying to reproduce a crash and have not yet been able to. I have just "played" from the beginning as I see the Delay Audio filter on the first track. I will try a different computer/operating system version to see if I can reproduce. Thanks for providing the demo file and your temporary solution. I will let you know if I can cause a crash also. |
|
|
ED: I might have just now found a workaround! Shutting off "delay audio" seems - thusfar - to do the trick! I can work the delay into the chorus instead. |
|
|
KeyPerson_3.xml (66,784 bytes) cinelerra_1591335.dmp (289,261 bytes) |
- Anonymous
